LGTM,thanks.
On Mon, Feb 3, 2014 at 8:56 PM, Klaus Aehlig <[email protected]> wrote: > In this way, we cann pass through the opaque parameters > required for disk creation and modification in the case of > external storage. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > src/Ganeti/OpParams.hs | 1 + > test/hs/Test/Ganeti/OpCodes.hs | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/Ganeti/OpParams.hs b/src/Ganeti/OpParams.hs > index 11d62f6..5453b89 100644 > --- a/src/Ganeti/OpParams.hs > +++ b/src/Ganeti/OpParams.hs > @@ -357,6 +357,7 @@ $(buildObject "IDiskParams" "idisk" > , optionalField $ simpleField C.idiskName [t| NonEmptyString |] > , optionalField $ simpleField C.idiskProvider [t| NonEmptyString |] > , optionalField $ simpleField C.idiskSpindles [t| Int |] > + , andRestArguments "opaque" > ]) > > -- | Disk changes type for OpInstanceRecreateDisks. This is a bit > diff --git a/test/hs/Test/Ganeti/OpCodes.hs > b/test/hs/Test/Ganeti/OpCodes.hs > index 5157801..2f5a233 100644 > --- a/test/hs/Test/Ganeti/OpCodes.hs > +++ b/test/hs/Test/Ganeti/OpCodes.hs > @@ -95,7 +95,7 @@ instance Arbitrary IDiskParams where > arbitrary = IDiskParams <$> arbitrary <*> arbitrary <*> > genMaybe genNameNE <*> genMaybe genNameNE <*> > genMaybe genNameNE <*> genMaybe genNameNE <*> > - genMaybe genNameNE <*> arbitrary > + genMaybe genNameNE <*> arbitrary <*> genAndRestArguments > > instance Arbitrary RecreateDisksInfo where > arbitrary = oneof [ pure RecreateDisksAll > -- > 1.9.0.rc1.175.g0b1dcb5 > >
