On Wed, Feb 5, 2014 at 12:51 PM, Jose A. Lopes <[email protected]> wrote: > There's no need to put the affected files in the title because they > are part of the patch. The important part here is to make sure that > someone who is unfamiliar with your patch series can look at the title > and understand what you are trying to do.
I simply figured that "component: change" would be a fairly terse and obvious way to describe what the commit does (in the gluster patch series, many commits were "gluster: do this", "gluster: do that"). > The refactoring you did seems pretty good. > Only two things: > > Instead of > algo: add GetRepeatedKeys > how about? > Add helper function to detect duplicate keys in OS params The helper function is more generic than that. -- Raffa Santi Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
