On Wed, Feb 05, 2014 at 08:32:41AM +0100, Santi Raffa wrote:
> ...and a couple others:
LGTM to the interdiff.
But the previous email still has some comments to address.
> diff --git a/src/Ganeti/OpParams.hs b/src/Ganeti/OpParams.hs
> index 1032097..d90b362 100644
> --- a/src/Ganeti/OpParams.hs
> +++ b/src/Ganeti/OpParams.hs
> @@ -1212,23 +1212,15 @@ pTempOsParams =
>
> pTempOsParamsPrivate :: Field
> pTempOsParamsPrivate =
> - field { fieldDoc = "meh"
> - -- fieldShow = Just [| \(_,y) -> showPrivateJSObject y |]
> - }
> - where field =
> - withDoc "Private OS parameters for instance reinstalls" .
> - optionalField $
> - simpleField "osparams_private" [t| JSObject (Private JSValue) |]
> + withDoc "Private OS parameters for instance reinstalls" .
> + optionalField $
> + simpleField "osparams_private" [t| JSObject (Private JSValue) |]
>
> pTempOsParamsSecret :: Field
> pTempOsParamsSecret =
> - field { fieldDoc = "meh"
> - -- fieldShow = Just [| \(_,y) -> showPrivateJSObject y |]
> - }
> - where field =
> - withDoc "Secret OS parameters for instance reinstalls" .
> - optionalField $
> - simpleField "osparams_secret" [t| JSObject (Private JSValue) |]
> + withDoc "Secret OS parameters for instance reinstalls" .
> + optionalField $
> + simpleField "osparams_secret" [t| JSObject (Private JSValue) |]
>
> pShutdownTimeout :: Field
> pShutdownTimeout =
>
>
> --
> Raffa Santi
> Google Germany GmbH
> Dienerstr. 12
> 80331 München
>
>
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschäftsführer: Graham Law, Christine Elizabeth Flores
--
Jose Antonio Lopes
Ganeti Engineering
Google Germany GmbH
Dienerstr. 12, 80331, München
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores
Steuernummer: 48/725/00206
Umsatzsteueridentifikationsnummer: DE813741370
