LGTM, thanks!
On Wed, Mar 26, 2014 at 10:26 AM, Apollon Oikonomopoulos <[email protected]>wrote: > KVM NIC hotplugging requires python-fdsend to be installed, but this > is only reported in the hotplug design document. We add mentions in > INSTALL and NEWS. > > Signed-off-by: Apollon Oikonomopoulos <[email protected]> > --- > INSTALL | 2 ++ > NEWS | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/INSTALL b/INSTALL > index dfccc8a..fe2d1dc 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -43,6 +43,8 @@ Before installing, please verify that you have the > following programs: > ``ganeti-listrunner`` > - `affinity Python module <http://pypi.python.org/pypi/affinity/0.1.0>`_, > optional python package for supporting CPU pinning under KVM > +- `fdsend Python module <https://gitorious.org/python-fdsend>`_, > + optional Python package for supporting NIC hotplugging under KVM > - `qemu-img <http://qemu.org/>`_, if you want to use ``ovfconverter`` > - `fping <http://fping.sourceforge.net/>`_ > - `Python IP address manipulation library > diff --git a/NEWS b/NEWS > index cc1153a..b731e4d 100644 > --- a/NEWS > +++ b/NEWS > @@ -77,6 +77,7 @@ New features > - one can not (yet) hotplug a disk using userspace access mode for RBD > - in case of a downgrade instances should suffer a reboot in order to > be migratable (due to core change of runtime files) > + - ``python-fdsend`` is required for NIC hotplugging. > > Misc changes > ~~~~~~~~~~~~ > @@ -102,6 +103,9 @@ Python > - The version requirements for ``python-mock`` have increased to at least > version 1.0.1. It is still used for testing only. > > +- ``python-fdsend`` (https://gitorious.org/python-fdsend) is optional > + but required for KVM NIC hotplugging to work. > + > Since 2.10.0 rc3 > ~~~~~~~~~~~~~~~~ > > -- > 1.9.0 > > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
