LGTM, thanks.
On Fri, Apr 11, 2014 at 3:46 PM, Klaus Aehlig <[email protected]> wrote: > On Fri, Apr 11, 2014 at 03:38:28PM +0200, Petr Pudlák wrote: > > As discussed offline, I'd suggest to add a comment to the docs for the > > function that the returned set only contains the newly acquired locks and > > locks that the owner already held aren't mentioned in the result. > > > > > Interdiff > > diff --git a/src/Ganeti/Locking/Waiting.hs b/src/Ganeti/Locking/Waiting.hs > index 1f403c5..9096ddc 100644 > --- a/src/Ganeti/Locking/Waiting.hs > +++ b/src/Ganeti/Locking/Waiting.hs > @@ -326,7 +326,8 @@ intersectLocks :: (Lock a, Ord b, Ord c) > intersectLocks locks = freeLocksPredicate (not . flip elem locks) > > -- | Opprotunistically allocate locks for a given owner; return the set > --- of actually acquired locks. > +-- of newly actually acquired locks (i.e., locks already held before are > +-- not mentioned). > opportunisticLockUnion :: (Lock a, Ord b, Ord c) > => b > -> [(a, L.OwnerState)] > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
