Sorry, I missed it's not in the commit. LGTM for the patch.
On Fri, Apr 11, 2014 at 3:51 PM, Klaus Aehlig <[email protected]> wrote: > > > -- | Load a lock allocation from disk. > > > -loadLockAllocation :: FilePath -> ResultG GanetiLockAllocation > > > +loadLockAllocation :: FilePath -> ResultG GanetiLockWaiting > > > loadLockAllocation = > > > liftIO . readFile > > > - >=> fromJResultE "parsing lock allocation" . J.decodeStrict > > > + >=> fromJResultE "parsing lock waiting structure" . J.decodeStrict > > > > > > -- | Write lock allocation to disk, overwriting any previously lock > > > -- allocation stored there. > > > > > > > Just nitpicking: s/previously/previous/ > > As the mentioned line is not part of the reviewed commit, I suggest fixing > this in a separare patch at the end of the patch series. > > commit 79e125978ea4c5a2b5ee4fd2107fec7d40c49b37 > Author: Klaus Aehlig <[email protected]> > Date: Fri Apr 11 15:49:37 2014 +0200 > > fix typo > > diff --git a/src/Ganeti/Locking/Locks.hs b/src/Ganeti/Locking/Locks.hs > index e9080fb..3a1fdba 100644 > --- a/src/Ganeti/Locking/Locks.hs > +++ b/src/Ganeti/Locking/Locks.hs > @@ -238,7 +238,7 @@ loadLockAllocation = > liftIO . readFile > >=> fromJResultE "parsing lock waiting structure" . J.decodeStrict > > --- | Write lock allocation to disk, overwriting any previously lock > +-- | Write lock allocation to disk, overwriting any previous lock > -- allocation stored there. > writeLocks :: (MonadBase IO m, MonadError GanetiException m, MonadLog m) > => FilePath -> GanetiLockWaiting -> m () > > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
