LGTM, thanks
On Wed, Apr 9, 2014 at 9:53 AM, Jose A. Lopes <[email protected]> wrote: > This is an intermediary step before extracting most of the body of > 'GenerateTapName' to a separate function that can be reused by the Xen > hypervisor as well. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > lib/hypervisor/hv_kvm/__init__.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/hypervisor/hv_kvm/__init__.py > b/lib/hypervisor/hv_kvm/__init__.py > index 4a80b2d..2e1dd47 100644 > --- a/lib/hypervisor/hv_kvm/__init__.py > +++ b/lib/hypervisor/hv_kvm/__init__.py > @@ -1462,7 +1462,7 @@ class KVMHypervisor(hv_base.BaseHypervisor): > raise errors.HypervisorError("Failed to start instance %s" % name) > > @staticmethod > - def _GenerateTapName(nic): > + def _GenerateKvmTapName(nic): > """Generate a TAP network interface name for a NIC. > > This helper function generates a special TAP network interface > @@ -1595,7 +1595,7 @@ class KVMHypervisor(hv_base.BaseHypervisor): > > for nic_seq, nic in enumerate(kvm_nics): > tapname, tapfd = OpenTap(vnet_hdr=vnet_hdr, > - name=self._GenerateTapName(nic)) > + name=self._GenerateKvmTapName(nic)) > tapfds.append(tapfd) > taps.append(tapname) > if kvm_supports_netdev: > -- > 1.9.1.423.g4596e3a > >
