LGTM. Thanks, Jose
On Apr 15 17:33, Klaus Aehlig wrote: > On Tue, Apr 15, 2014 at 05:25:39PM +0200, Klaus Aehlig wrote: > > Signed-off-by: Klaus Aehlig <[email protected]> > > --- > > src/Ganeti/HTools/Backend/IAlloc.hs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/Ganeti/HTools/Backend/IAlloc.hs > > b/src/Ganeti/HTools/Backend/IAlloc.hs > > index 6c8c8ab..b76bc58 100644 > > --- a/src/Ganeti/HTools/Backend/IAlloc.hs > > +++ b/src/Ganeti/HTools/Backend/IAlloc.hs > > @@ -212,7 +212,7 @@ parseData now body = do > > rname <- extrReq "name" > > req_nodes <- extrReq "required_nodes" > > inew <- parseBaseInstance rname request > > - let io = snd inew > > + let io = updateExclTags (extractExTags ctags) $ snd inew > > return $ Allocate io req_nodes > > | optype == C.iallocatorModeReloc -> > > do > > For multi-allocation we have to do the same thing, so I'd like to include > the following interdiff. > > commit 26fb6eb53e6f383b07e1804e2e1f5ec9ea8991e7 > Author: Klaus Aehlig <[email protected]> > Date: Tue Apr 15 17:32:26 2014 +0200 > > INTERDIFF > > diff --git a/src/Ganeti/HTools/Backend/IAlloc.hs > b/src/Ganeti/HTools/Backend/IAlloc.hs > index b76bc58..4c670ac 100644 > --- a/src/Ganeti/HTools/Backend/IAlloc.hs > +++ b/src/Ganeti/HTools/Backend/IAlloc.hs > @@ -247,7 +247,8 @@ parseData now body = do > rname <- extrFromReq r "name" > req_nodes <- extrFromReq r "required_nodes" > inew <- parseBaseInstance rname r > - let io = snd inew > + let io = updateExclTags (extractExTags > ctags) > + $ snd inew > return (io, req_nodes)) inst_reqs > return $ MultiAllocate prqs > | otherwise -> fail ("Invalid request type '" ++ optype ++ "'") > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores -- Jose Antonio Lopes Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
