LGTM, thanks
On Tue, May 13, 2014 at 10:43 AM, 'Jose A. Lopes' via ganeti-devel < [email protected]> wrote: > ... given that 'lu.instance' does not exist in all LUs. > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > lib/cmdlib/common.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/cmdlib/common.py b/lib/cmdlib/common.py > index 59bd855..0419953 100644 > --- a/lib/cmdlib/common.py > +++ b/lib/cmdlib/common.py > @@ -1036,7 +1036,7 @@ def IsInstanceRunning(lu, instance, > check_user_shutdown=False): > > if check_user_shutdown: > # One more check to be made - whether the instance was shutdown by > the user > - full_hvparams = lu.cfg.GetClusterInfo().FillHV(lu.instance) > + full_hvparams = lu.cfg.GetClusterInfo().FillHV(instance) > inst_info = lu.rpc.call_instance_info(pnode_uuid, instance.name, > instance.hypervisor, > full_hvparams) > inst_info.Raise("Can't retrieve instance information for instance %s" > % > -- > 1.9.1.423.g4596e3a > >
