Making the temporary disk readonly has absolutely no advantages and it
has the disadvantage that it prevents the OS install helper from
saving temporary data to it, for example, when downloading the OS
install package which is necessary to run the OS scripts.

Signed-off-by: Jose A. Lopes <[email protected]>
---
 lib/cmdlib/instance.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/lib/cmdlib/instance.py b/lib/cmdlib/instance.py
index 3f8fbb1..36a7a5c 100644
--- a/lib/cmdlib/instance.py
+++ b/lib/cmdlib/instance.py
@@ -1567,15 +1567,9 @@ class LUInstanceCreate(LogicalUnit):
 
     disk_size = DetermineImageSize(self, install_image, instance.primary_node)
 
-    # KVM does not support readonly disks
-    if instance.hypervisor == constants.HT_KVM:
-      disk_access = constants.DISK_RDWR
-    else:
-      disk_access = constants.DISK_RDONLY
-
     with TemporaryDisk(self,
                        instance,
-                       [(constants.DT_PLAIN, disk_access, disk_size)],
+                       [(constants.DT_PLAIN, constants.DISK_RDWR, disk_size)],
                        feedback_fn):
       feedback_fn("Activating instance disks")
       StartInstanceDisks(self, instance, False)
-- 
1.9.1.423.g4596e3a

Reply via email to