ACK, I suggest to change the comment to -- Note: We could consider using MonadRandom from the package of the same name.
On Wed, May 28, 2014 at 4:17 PM, Klaus Aehlig <[email protected]> wrote: > On Wed, May 28, 2014 at 04:09:09PM +0200, 'Petr Pudlak' via ganeti-devel > wrote: > > .. since it's a general, randomized function. > > > > Signed-off-by: Petr Pudlak <[email protected]> > > --- > > src/Ganeti/Utils/Random.hs | 14 ++++++++++++++ > > src/Ganeti/WConfd/TempRes.hs | 10 ---------- > > 2 files changed, 14 insertions(+), 10 deletions(-) > > > +-- FIXME: These computation would be much easier expressed using > MonadRandom > > +-- from the package of the same name. > > Maybe downgrade to a remark, or leave out alltogether. In it's current > form, > it is not really a problem that we're not using MonadRandom. > > > Rest LGTM, no need to resend (regardless on whether you want to change the > comment > or not). > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
