This is at least a bit peculiar. Anyway, LGTM, thanks!
On Wed, May 28, 2014 at 12:37 PM, 'Jose A. Lopes' via ganeti-devel < [email protected]> wrote: > .. and additional local variables > > Signed-off-by: Jose A. Lopes <[email protected]> > --- > lib/backend.py | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/lib/backend.py b/lib/backend.py > index 4e13ae3..a016913 100644 > --- a/lib/backend.py > +++ b/lib/backend.py > @@ -1424,15 +1424,11 @@ def GetInstanceListForHypervisor(hname, > hvparams=None, > - instance2.example.com > > """ > - results = [] > try: > - hv = get_hv_fn(hname) > - names = hv.ListInstances(hvparams=hvparams) > - results.extend(names) > + return get_hv_fn(hname).ListInstances(hvparams=hvparams) > except errors.HypervisorError, err: > _Fail("Error enumerating instances (hypervisor %s): %s", > hname, err, exc=True) > - return results > > > def GetInstanceList(hypervisor_list, all_hvparams=None, > -- > 1.9.1.423.g4596e3a > >
