LGTM On Jun 17, 2014 3:55 PM, "'Klaus Aehlig' via ganeti-devel" < [email protected]> wrote:
> With recent changes to the passing of nic-parameters, the old style > of calling gnt-network connect was stopped being supported. Change > the tests accordingly. > > Signed-off-by: Klaus Aehlig <[email protected]> > --- > qa/qa_network.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/qa/qa_network.py b/qa/qa_network.py > index 4dd532f..8fa16c0 100644 > --- a/qa/qa_network.py > +++ b/qa/qa_network.py > @@ -102,12 +102,11 @@ def TestNetworkConnect(): > AssertCommand(["gnt-group", "add", group1]) > AssertCommand(["gnt-network", "add", "--network", "192.0.2.0/24", > network1]) > > - AssertCommand(["gnt-network", "connect", network1, mode, link, group1]) > + AssertCommand(["gnt-network", "connect", "--nic-parameters", nicparams, > + network1, group1]) > > TestNetworkList() > > - AssertCommand(["gnt-network", "connect", "--nic-parameters", nicparams, > - network1, group1]) > AssertCommand(["gnt-network", "disconnect", network1, group1]) > > AssertCommand(["gnt-group", "remove", group1]) > -- > 2.0.0.526.g5318336 > >
