LGTM, thanks
On Wed, Jul 16, 2014 at 9:20 AM, 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote: > On Tue, Jul 15, 2014 at 12:40:12PM +0200, Klaus Aehlig wrote: > > For some reason, find does stat the current working directory, > > which, when invoked via cron, may or may not be readable by the > > process (issue 880). Therefore, first change to a directory that > > is definitely accessible to the process; the directory it logs > > into is such a safe place. > > > > Signed-off-by: Klaus Aehlig <[email protected]> > > --- > > daemons/ganeti-cleaner.in | 3 +++ > > 1 file changed, 3 insertions(+) > > Unfortunately, our tests pass some unjustified relative paths. > So I'd like to include the following interdiff. > > commit af82810633aca03593f95d3516d4c10c8f4b005f > Author: Klaus Aehlig <[email protected]> > Date: Tue Jul 15 14:49:27 2014 +0200 > > INTERDIFF > > diff --git a/test/py/ganeti-cleaner_unittest.bash > b/test/py/ganeti-cleaner_unittest.bash > index bf57b76..cf38f73 100755 > --- a/test/py/ganeti-cleaner_unittest.bash > +++ b/test/py/ganeti-cleaner_unittest.bash > @@ -24,7 +24,11 @@ set -o pipefail > export PYTHON=${PYTHON:=python} > > GNTC=daemons/ganeti-cleaner > -CCE=tools/check-cert-expired > +CCE=$PWD/tools/check-cert-expired > + > +if [ "x$PYTHONPATH" = "x." ] > +then export PYTHONPATH=$PWD > +fi > > err() { > echo "$@" > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
