LGTM, thanks
On Wed, Aug 27, 2014 at 10:17 PM, Yuto KAWAMURA(kawamuray) < [email protected]> wrote: > This commit discards comments in LXCHypervisor which are already > solved, or already not accurate. > > Signed-off-by: Yuto KAWAMURA(kawamuray) <[email protected]> > --- > lib/hypervisor/hv_lxc.py | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/lib/hypervisor/hv_lxc.py b/lib/hypervisor/hv_lxc.py > index 332c3dd..74db9ce 100644 > --- a/lib/hypervisor/hv_lxc.py > +++ b/lib/hypervisor/hv_lxc.py > @@ -43,17 +43,6 @@ from ganeti.errors import HypervisorError > class LXCHypervisor(hv_base.BaseHypervisor): > """LXC-based virtualization. > > - TODO: > - - move hardcoded parameters into hypervisor parameters, once we > - have the container-parameter support > - > - Problems/issues: > - - LXC is very temperamental; in daemon mode, it succeeds or fails > - in launching the instance silently, without any error > - indication, and when failing it can leave network interfaces > - around, and future successful startups will list the instance > - twice > - > """ > _ROOT_DIR = pathutils.RUN_DIR + "/lxc" > _LOG_DIR = pathutils.LOG_DIR + "/lxc" > -- > 2.0.4 > > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores Steuernummer: 48/725/00206 Umsatzsteueridentifikationsnummer: DE813741370
