******** NOTE: pull-request-emailer ******** * User 'nh2' has submitted a pull request on * https://github.com/ganeti-github-testing/ganeti-test-1/pull/5 * * It has been converted to a patch series by * nikl...@google.com ***************************************************
Removes unused code, code that can be derived automatically, and code that can be written in a more general way. Niklas Hambuechen (10): Remove unused code. Types: Add `instance Applicative Private` Rename Ganeti.Utils.MonadPlus to Ganeti.Utils.Monad. Auto-derive instances where possible Utils.Monad: Add anyM and allM Query.Filter: Simplify `evaluateFilter` recursion Query.Filter: Simplify `wrapGetter` Query.Filter: Add evaluateFilterM Query.Filter: Simplify `evaluateFilter` Query.Filter: `evaluateFilter` -> `evaluateQueryFilter` Makefile.am | 2 +- src/Ganeti/BasicTypes.hs | 14 ++-- src/Ganeti/JSON.hs | 18 ++--- src/Ganeti/Logging.hs | 6 +- src/Ganeti/Logging/WriterLog.hs | 35 ++-------- src/Ganeti/Objects/BitArray.hs | 1 - src/Ganeti/Query/Exec.hs | 2 +- src/Ganeti/Query/Filter.hs | 136 ++++++++++++++++++++++--------------- src/Ganeti/Query/Language.hs | 31 ++------- src/Ganeti/Query/Query.hs | 8 +-- src/Ganeti/Storage/Lvm/LVParser.hs | 2 +- src/Ganeti/THH.hs | 22 +----- src/Ganeti/THH/HsRPC.hs | 26 ++----- src/Ganeti/THH/Types.hs | 6 +- src/Ganeti/Types.hs | 10 +-- src/Ganeti/Utils/Monad.hs | 64 +++++++++++++++++ src/Ganeti/Utils/MonadPlus.hs | 51 -------------- src/Ganeti/Utils/Validate.hs | 15 +--- src/Ganeti/WConfd/Monad.hs | 24 +------ src/Ganeti/WConfd/Server.hs | 2 +- src/Ganeti/WConfd/TempRes.hs | 2 +- 21 files changed, 202 insertions(+), 275 deletions(-) create mode 100644 src/Ganeti/Utils/Monad.hs delete mode 100644 src/Ganeti/Utils/MonadPlus.hs -- 2.1.0.rc2.206.gedb03e5
