* 'Klaus Aehlig' via ganeti-devel <[email protected]> [2014-10-02 13:04:00 +0200]:
> > Hi Dimara, > > > A reasonable work around is to change the > > --ignore-hvversions to --check-hvversions and set it False by default. > > This would not break compatibility (but it would require a change in > > external scripts that would like to use this new feature). > > I'm not really happy with this work around as the main point of > issue 945 was to have the save behaviour the default. > I thought so.. > > Still since this is supposed to by hypervisor specific, I guess the > > proper way to implement it is the following way: > > > > - Get hypervisor version source (but the one of the running instance > > and not the node's one). In Xen it should be the same but in KVM it > > requires a monitor call. I guess this requires extending the RPC > > mechanism. > > - Get the hypervisor version of target node. This is done already. > > - Introduce new classmethod of BaseHypervisor (e.g. > > IsMigrationSupportedBetween(cls, src, tgt)) that takes source and > > target version and returns True or False (and move it out from > > utils). > > - And based on the opcode's options abort or not. > > > > What do you think? > > I guess you're right. Making it hypervisor specific is the correct way of > doing it and we should do it, even if it is a lot more work. > Good. It would be great to have it in the next release (2.13) since now (master) the machine_version feature gets overriden by default and kinda breaks compatibility.. Thanks, dimara > Thanks, > Klaus > > > -- > Klaus Aehlig > Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
signature.asc
Description: Digital signature
