> > +-- | The exclusion tag prefix.
> > +exTagsPrefix :: String
> > +exTagsPrefix = "htools:iextags:"
> > +
> >
> 
> I suggest adding another sentence that shortly explains what exclusion tags
> are for.
> 
> Rest LGTM, no need to resend.


FYI.

commit d591d7472cc4df7dbe5800a6e58ced30af5d872a
Author: Klaus Aehlig <[email protected]>
Date:   Wed Oct 8 10:45:08 2014 +0200

    Interdiff [PATCH master 01/11] Move exclusion-tags prefix to a separate 
module

diff --git a/src/Ganeti/HTools/Tags.hs b/src/Ganeti/HTools/Tags.hs
index abb090a..7388297 100644
--- a/src/Ganeti/HTools/Tags.hs
+++ b/src/Ganeti/HTools/Tags.hs
@@ -56,7 +56,9 @@ import qualified Ganeti.HTools.Node as Node
 
 -- * Constants
 
--- | The exclusion tag prefix.
+-- | The exclusion tag prefix. Instance tags starting with this prefix
+-- describe a service provided by the instance. Instances providing the
+-- same service at not places on the same node.
 exTagsPrefix :: String
 exTagsPrefix = "htools:iextags:"
 


-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to