On Mon, Nov 03, 2014 at 08:45:19PM +0100, 'Niklas Hambuechen' via ganeti-devel 
wrote:
> It turns out that GHC 7.8's -dynamic-too is forbidden not only for
> profiling builds object files, but also for those using HPC coverage.
> 
> This commit accordingly renames HFLAGS_NOPROF to HFLAGS_DYNAMIC
> (since it now is not conditional on profiling any more),
> and makes sure that it is not used for profiling or HPC.
> 
> This way we achieve that, for profiling+coverage builds
>   - .dyn_o files are available for use in TH in the following 3 cases
>   - .o files are for the normal binaries
>   - .hpc_o files are for coverage-enabled test binaries
>   - .prof_o files are for profiling binaries
> 
> We make .hpc_o files depend on the .o files because the creation of
> the .o files will also create the .so files needed for TH.
> This was already in place for .prof_o files.
> 
> This requires that HFLAGS now also contains `-itest/hs` since
> the rule for .o files is now also responsible for building .o/.so files
> in test/hs.
> 
> Signed-off-by: Niklas Hambuechen <nikl...@google.com>
> ---
>  Makefile.am | 42 +++++++++++++++++++++++++-----------------
>  1 file changed, 25 insertions(+), 17 deletions(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to