On Thu, Nov 06, 2014 at 12:30:45AM +0200, Alex Pyrgiotis wrote: > It is not an error sign for a configuration to have detached disks, since they > can be handled from now on by the attach/detach operations. > > Signed-off-by: Alex Pyrgiotis <[email protected]> > > diff --git a/lib/config.py b/lib/config.py > index d47ee22..6b8d237 100644 > --- a/lib/config.py > +++ b/lib/config.py > @@ -1033,8 +1033,6 @@ class ConfigWriter(object): > @param result: list containing diagnostic messages > > """ > - instance_disk_uuids = [d for insts in data.instances.values() > - for d in insts.disks] > for disk_uuid in data.disks: > disk = data.disks[disk_uuid] > result.extend(["disk %s error: %s" % (disk.uuid, msg) > @@ -1042,9 +1040,6 @@ class ConfigWriter(object): > if disk.uuid != disk_uuid: > result.append("disk '%s' is indexed by wrong UUID '%s'" % > (disk.name, disk_uuid)) > - if disk.uuid not in instance_disk_uuids: > - result.append("disk '%s' is not attached to any instance" % > - disk.uuid) > > def _UnlockedVerifyConfig(self): > """Verify function. > -- > 1.7.10.4 >
LGTM -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
