On Mon, Nov 17, 2014 at 11:29 AM, 'Aaron Karper' via ganeti-devel <[email protected]> wrote: > Because the new definition of diskless is not having disks, > attaching/adding disks to the instance should be possible. > > Signed-off-by: Aaron Karper <[email protected]> > --- > lib/cmdlib/instance_set_params.py | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/lib/cmdlib/instance_set_params.py > b/lib/cmdlib/instance_set_params.py > index f6fd4bf..0619a96 100644 > --- a/lib/cmdlib/instance_set_params.py > +++ b/lib/cmdlib/instance_set_params.py > @@ -704,10 +704,6 @@ class LUInstanceSetParams(LogicalUnit): > " --no-wait-for-sync given.", > errors.ECODE_INVAL) > > - if self.op.disks and not self.instance.disks: > - raise errors.OpPrereqError("Disk operations not supported for" > - " diskless instances", errors.ECODE_INVAL) > - > def _PrepareDiskMod(_, disk, params, __): > disk.name = params.get(constants.IDISK_NAME, None) > > -- > 2.1.0.rc2.206.gedb03e5 >
LGTM, thanks. Michele -- Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
