Therefore, to find out if an instance is diskless, check that the instance itself has no disks, not that the number of broken disks is 0.
Signed-off-by: Klaus Aehlig <[email protected]> --- lib/cmdlib/instance_storage.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cmdlib/instance_storage.py b/lib/cmdlib/instance_storage.py index c5258ae..a627565 100644 --- a/lib/cmdlib/instance_storage.py +++ b/lib/cmdlib/instance_storage.py @@ -2338,8 +2338,8 @@ class TLReplaceDisks(Tasklet): self.disks = range(len(self.instance.disks)) disks = self.cfg.GetInstanceDisks(self.instance.uuid) - if (not self.disks or - not utils.AllDiskOfType(map(lambda i: disks[i], self.disks), + if (not disks or + not utils.AllDiskOfType(map(lambda i: disks[i], disks), [constants.DT_DRBD8])): raise errors.OpPrereqError("Can only run replace disks for DRBD8-based" " instances", errors.ECODE_INVAL) -- 2.2.0.rc0.207.ga3a616c
