LGTM, thanks

On Fri Dec 05 2014 at 11:24:56 AM 'Klaus Aehlig' via ganeti-devel <
[email protected]> wrote:

> Add a target to manually run the python tests, and no other
> tests. In the same way as the hs-tests target simplifies testing
> Haskell changes while developing Haskell code, this target
> simplifies developing python code.
>
> Signed-off-by: Klaus Aehlig <[email protected]>
> Signed-off-by: Niklas Hambuechen <[email protected]>
> Reviewed-by: Niklas Hambuechen <[email protected]>
>
> Cherry-picked from 5b8754f4f
>
> Signed-off-by: Klaus Aehlig <[email protected]>
> ---
>  Makefile.am | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 060cc6d..8033db1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -2365,6 +2365,14 @@ hs-tests: test/hs/htest
>         @rm -f htest.tix
>         ./test/hs/htest
>
> +.PHONY: py-tests
> +py-tests: $(python_tests) ganeti $(built_python_sources)
> +       error=; \
> +       for file in $(python_tests); \
> +         do if ! $(TESTS_ENVIRONMENT) $$file; then error=1; fi; \
> +       done; \
> +       test -z "$$error"
> +
>  .PHONY: hs-shell-%
>  hs-shell-%: test/hs/hpc-htools test/hs/hpc-mon-collector \
>              $(HS_BUILT_TEST_HELPERS)
> --
> 2.2.0.rc0.207.ga3a616c
>
>

Reply via email to