On Fri, Jan 09, 2015 at 04:07:07PM +0000, 'Aaron Karper' via ganeti-devel wrote: > Rebased on master and pushed! >
Great! I will now update the other patch regarding the file template and will resend it shortly. Thanks, Alex > On Thu Dec 18 2014 at 9:55:31 PM Alex Pyrgiotis <[email protected]> wrote: > > > Hi everybody, > > > > This is the second iteration for the patch regarding the implementation > > of the attach/detach operations for disks. To get some background, the > > original message that introduced this patch series follows below: > > > > > This patch series implements the necessary logic for the attach/detach > > > operation on disks. This functionality will allow users to remove a > > > disk from an instance and attach it later on to another one, or keep > > > it for forensic reasons. The latter part means that the Ganeti > > > configuration now supports having detached disks. > > > > > > In order to document this new functionality, we have extended the man > > > page for gnt-instance, as well as the design doc for disks. Also, to > > > make sure that we don't introduce any new bugs, we have added many new > > > unit tests and extended older ones. Moreover, we have extended the > > > burnin tool in order to live-test this new functionality on an > > > existing cluster. > > > > > > Finally, a related patch about file-based instances is in the works > > > and will be sent in a couple of days. > > > > Note that this patch has already been sent and I will update it once > > this patch series is merged. > > > > Finally, thanks Aaron for taking the time to look into the code and > > postponing your disk template patch. It is much appreciated. > > > > Cheers, > > Alex > > > > > > Alex Pyrgiotis (19): > > config: Use disk name to get its info > > config: Fix docstring of _UnlockedGetInstanceNodes > > cmdlib: Turn index code to functions > > cmdlib: Return RPC result in AssembleInstanceDisks > > config: Create wrappers for attach/detach ops > > constants: Add attach/detach and UUID constant > > cmdlib: Add checks for attach/detach > > cmdlib: Add core attach/detach logic > > config: Remove checks for detached disks > > burnin: Test if attach/detach works properly > > tests.config: Add test for GetDiskInfoByName > > tests.cmdlib: Test index operations > > tests.opcodes/client: Add test for constants > > tests.config: Test attach/detach wrappers > > tests.cmdlib: Check if attach/detach checks work > > tests.cmdlib: Extend tests for _ApplyContainerMods > > tests.cluster: Add test for VerifyConfig > > doc: Extend the design document for disks > > man: Update the gnt-instance man page > > > > Ilias Tsitsimpis (2): > > Implement GetAllDisksInfo in config > > AllocateDRBDMinor per disk, not per instance > > > > doc/design-disks.rst | 49 ++- > > lib/client/gnt_instance.py | 53 ++- > > lib/cmdlib/cluster/verify.py | 43 ++- > > lib/cmdlib/instance.py | 10 +- > > lib/cmdlib/instance_create.py | 3 +- > > lib/cmdlib/instance_migration.py | 4 +- > > lib/cmdlib/instance_set_params.py | 190 ++++++++-- > > lib/cmdlib/instance_storage.py | 48 ++- > > lib/cmdlib/instance_utils.py | 116 ++++-- > > lib/config/__init__.py | 140 +++++-- > > lib/tools/burnin.py | 178 ++++++--- > > man/gnt-instance.rst | 25 +- > > pylintrc | 2 +- > > src/Ganeti/Config.hs | 1 + > > src/Ganeti/Constants.hs | 8 +- > > src/Ganeti/Types.hs | 4 + > > src/Ganeti/WConfd/Core.hs | 14 +- > > src/Ganeti/WConfd/TempRes.hs | 40 +- > > test/py/cmdlib/cluster_unittest.py | 6 + > > test/py/cmdlib/instance_unittest.py | 485 > > ++++++++++++++++++++---- > > test/py/ganeti.client.gnt_instance_unittest.py | 31 +- > > test/py/ganeti.config_unittest.py | 119 ++++++ > > test/py/ganeti.opcodes_unittest.py | 3 + > > test/py/testutils/config_mock.py | 20 +- > > 24 files changed, 1282 insertions(+), 310 deletions(-) > > > > -- > > 1.7.10.4 > > > >
