On Wed, May 20, 2015 at 02:01:34PM +0200, 'BSRK Aditya' via ganeti-devel wrote: > They include updateCluster, updateNode, > updateInstance, updateNodegroup, updateNetwork, > updateDisk. > > Signed-off-by: BSRK Aditya <[email protected]> > --- > src/Ganeti/WConfd/ConfigModifications.hs | 111 > +++++++++++++++++++++++++++++- > 1 file changed, 110 insertions(+), 1 deletion(-)
Generally looks good. Can you please resend the whole patch series, as two patches without context makes it hard to find the third one. Also, as discussed in person, can you also please change the modification operations to be repeatable (i.e., also accept if the serial on record is precisely one larger and also the object to be inserted is equal except for the incremented serial and the timestamp field). Thanks, Klaus -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
