Agreed. Also, I find it good practice to write the test first that proves the bug. Thus the order was kind natural in terms of how to approach this. I would have been fine with that too as it is a patch series.
On Wed, 10 Jun 2015 at 12:56 'Petr Pudlak' via ganeti-devel < [email protected]> wrote: > OK, as I only changed the order wrt to the LGTMed patches, I'm submitting > this updated series. > > On Wed, Jun 10, 2015 at 12:41:00PM +0200, Klaus Aehlig wrote: > >On Wed, Jun 10, 2015 at 11:57:13AM +0200, 'Petr Pudlak' via ganeti-devel > wrote: > >> Add the missing call and fix tests to check for it. > > > >The order of the patches is correct like this; I didn't look into the > >patches itself, as Helga already reviewed them. > > > >-- > >Klaus Aehlig > >Google Germany GmbH, Dienerstr. 12, 80331 Muenchen > >Registergericht und -nummer: Hamburg, HRB 86891 > >Sitz der Gesellschaft: Hamburg > >Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores >
