On Mon, Jun 15, 2015 at 10:21:49AM +0200, 'BSRK Aditya' via ganeti-devel wrote: > Removes config lock usage. > > Also add a mock implementation of RemoveInstanceDisk > for the python tests. Moved _UnlockedDetachInstanceDisk > to config_mock.py as it is no longer used by non test code. > > Signed-off-by: BSRK Aditya <[email protected]> > --- > lib/config/__init__.py | 41 > ++++---------------------------------- > test/py/testutils/config_mock.py | 32 +++++++++++++++++++++++++++++ > 2 files changed, 36 insertions(+), 37 deletions(-)
Please remove lint errors. E.g., > + instance_disks = self._UnlockedGetInstanceDisks(inst_uuid) > + _UpdateIvNames(idx, instance_disks[idx:]) ************* Module testutils.config_mock E0602:952:ConfigMock._UnlockedDetachInstanceDisk: Undefined variable '_UpdateIvNames' I guess you have to qualify the function name here. -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
