On Mon, Jun 22, 2015 at 03:27:15PM +0200, 'Petr Pudlak' via ganeti-devel wrote:
> From: Niklas Hambuechen <[email protected]>
> 
> This only appears on systems with QuickCheck >= 2.7.
> 
> For TestCommon, it happens because the QC qualified name is only used
> in the conditional section.
> Fixed by making the import conditional as well.
> 
> For Statistics, the `Test.Ganeti.TestCommon` import was not necessary
> for QC 2.7 because there `Test.QuickCheck` already provides `counterexample`.
> Fixed by giving an import list for `Test.QuickCheck`.
> 
> Signed-off-by: Niklas Hambuechen <[email protected]>
> Reviewed-by: Klaus Aehlig <[email protected]>
> 
> Cherry-picked-from: 53bec60146dd49339e1315bfad7884ae89cd39d9
> Signed-off-by: Petr Pudlak <[email protected]>
> ---
>  test/hs/Test/Ganeti/TestCommon.hs       | 2 ++
>  test/hs/Test/Ganeti/Utils/Statistics.hs | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)

LGTM

-- 
Klaus Aehlig
Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores

Reply via email to