On Tue, 7 Jul 2015 at 11:20 'Petr Pudlak' via ganeti-devel <
[email protected]> wrote:

> .. where it belongs, as ConfigData is defined in Ganeti.Objects.
>
> Signed-off-by: Petr Pudlak <[email protected]>
> ---
>  test/hs/Test/Ganeti/Objects.hs       | 3 +++
>  test/hs/Test/Ganeti/Query/Network.hs | 3 ---
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/hs/Test/Ganeti/Objects.hs
> b/test/hs/Test/Ganeti/Objects.hs
> index 89b1ce7..319e7ee 100644
> --- a/test/hs/Test/Ganeti/Objects.hs
> +++ b/test/hs/Test/Ganeti/Objects.hs
> @@ -342,6 +342,9 @@ instance Arbitrary IAllocatorParams where
>
>  $(genArbitrary ''Cluster)
>
> +instance Arbitrary ConfigData where
> +  arbitrary = genEmptyCluster 0 >>= genConfigDataWithNetworks
> +
>  instance Arbitrary AddressPool where
>    arbitrary = AddressPool . BA.fromList <$> arbitrary
>
> diff --git a/test/hs/Test/Ganeti/Query/Network.hs
> b/test/hs/Test/Ganeti/Query/Network.hs
> index 01cbb26..b252fde 100644
> --- a/test/hs/Test/Ganeti/Query/Network.hs
> +++ b/test/hs/Test/Ganeti/Query/Network.hs
> @@ -52,9 +52,6 @@ import Test.QuickCheck
>  import qualified Data.Map as Map
>  import Data.Maybe
>
> -instance Arbitrary ConfigData where
> -  arbitrary = genEmptyCluster 0 >>= genConfigDataWithNetworks
> -
>  -- | Check if looking up a valid network ID of a nodegroup yields
>  -- a non-Nothing result.
>  prop_getGroupConnection :: NodeGroup -> Property
> --
> 2.4.3.573.g4eafbef
>
>
LGTM, thanks
-- 

Helga Velroyen
Software Engineer
[email protected]

Google Germany GmbH
Dienerstraße 12
80331 München

Geschäftsführer: Graham Law, Christine Elizabeth Flores
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

Reply via email to