Thanks for the review.
I'm sorry, I missed updating the RPC defs. Consider this interdiff, please:
diff --git a/lib/rpc_defs.py b/lib/rpc_defs.py
index 9ea9e08..40feb0c 100644
--- a/lib/rpc_defs.py
+++ b/lib/rpc_defs.py
@@ -537,7 +537,6 @@ _NODE_CALLS = [
("node_uuid", None, "UUID of the node whose key is distributed"),
("node_name", None, "Name of the node whose key is distributed"),
("potential_master_candidates", None, "Potential master candidates"),
- ("ssh_port_map", None, "Map of nodes' SSH ports to be used for
transfers"),
("to_authorized_keys", None, "Whether the node's key should be added"
" to all nodes' 'authorized_keys' file"),
("to_public_keys", None, "Whether the node's key should be added"
@@ -550,7 +549,6 @@ _NODE_CALLS = [
("node_name", None, "Name of the node whose key is removed"),
("master_candidate_uuids", None, "List of UUIDs of master
candidates."),
("potential_master_candidates", None, "Potential master candidates"),
- ("ssh_port_map", None, "Map of nodes' SSH ports to be used for
transfers"),
("from_authorized_keys", None,
"If the key should be removed from the 'authorized_keys' file."),
("from_public_keys", None,
@@ -563,7 +561,6 @@ _NODE_CALLS = [
("node_ssh_keys_renew", MULTI, None, constants.RPC_TMO_SLOW, [
("node_uuids", None, "UUIDs of the nodes whose key is renewed"),
("node_names", None, "Names of the nodes whose key is renewed"),
- ("ssh_port_map", None, "Map of nodes' SSH ports to be used for
transfers"),
("master_candidate_uuids", None, "List of UUIDs of master
candidates."),
("potential_master_candidates", None, "Potential master candidates")],
None, None, "Renew all SSH key pairs of all nodes nodes."),
On Fri, 17 Jul 2015 at 13:21 Klaus Aehlig <[email protected]> wrote:
> On Fri, Jul 17, 2015 at 01:10:38PM +0200, 'Helga Velroyen' via
> ganeti-devel wrote:
> > Recently, the SSH port information was added to ssconf
> > file. This patch makes use of it when adding, removing,
> > or renewing SSH keys. The main benefit of it is to reduce
> > the signature of the backend functions and thus the RPC
> > load.
> >
> > Signed-off-by: Helga Velroyen <[email protected]>
> > ---
> > lib/backend.py | 23 ++++++++-----------
> > lib/cmdlib/cluster.py | 3 +--
> > lib/cmdlib/node.py | 14 ++++--------
> > lib/server/noded.py | 13 +++++------
> > lib/ssh.py | 22 ------------------
> > test/py/ganeti.backend_unittest.py | 46
> ++++++++++++++------------------------
> > 6 files changed, 37 insertions(+), 84 deletions(-)
>
> LGTM
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>
--
Helga Velroyen
Software Engineer
[email protected]
Google Germany GmbH
Dienerstraße 12
80331 München
Geschäftsführer: Graham Law, Christine Elizabeth Flores
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.
