LGTM, thanks On Wed, 19 Aug 2015 at 23:56 'Hrvoje Ribicic' via ganeti-devel < [email protected]> wrote:
> Commit fe6287b4 made the --user-shutdown switch meaningful for Xen, > preventing USER_DOWN reporting if disabled. The QA turned this switch > on for KVM, where it is needed to start the specialized daemon, but > not for Xen. This patch fixes the discrepancy. > > Signed-off-by: Hrvoje Ribicic <[email protected]> > --- > qa/qa_instance.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qa/qa_instance.py b/qa/qa_instance.py > index 6cbe96e..490fec0 100644 > --- a/qa/qa_instance.py > +++ b/qa/qa_instance.py > @@ -1306,7 +1306,10 @@ def _TestInstanceUserDownXen(instance): > primary = _GetInstanceField(instance.name, "pnode") > fn = lambda: AssertCommand(["xm", "shutdown", "-w", instance.name], > node=primary) > + > + AssertCommand(["gnt-cluster", "modify", "--user-shutdown=true"]) > _TestInstanceUserDown(instance, fn) > + AssertCommand(["gnt-cluster", "modify", "--user-shutdown=false"]) > > > @InstanceCheck(INST_UP, INST_UP, FIRST_ARG) > -- > 2.5.0.276.gf5e568e > > -- Helga Velroyen Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Graham Law, Christine Elizabeth Flores Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
