LGTM from my side as well. On Thu, Jan 21, 2016 at 6:26 PM, 'Brian Foley' via ganeti-devel < [email protected]> wrote:
> On Thu, Jan 21, 2016 at 06:12:03PM +0100, Klaus Aehlig wrote: > > > > Hi Brian, > > > > > I wonder is a 1MB buffer per socket a little aggressive? > > > > Note that that limit only applies to Haskell(!) daemons > > talking over domain sockets(!) (and, in fact, only to those > > daemons sending). So the maximum that can happen in parallel, > > is the following > > [snip] > > > So, even if the worst comes to the worst, and the 1MiB is fully > > used, we should be below 60MiB which still fits into dom0. > > > > But, if you prefer, we can also reduce that size to somehing like > > 8k or 32k. I just decided to go for the maximum buffering we can > > afford while still safely staying within the current dom0 limits. > > > > What do you tink? > > That's a lot better than my (mis)calculation! I'm OK with that, and > if it turns out to be a problem when we deploy it, we can always > adjust it again later. > > LGTM. > > Thanks, > Brian. > Hrvoje Ribicic Ganeti Engineering Google Germany GmbH Dienerstr. 12, 80331, München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
