> diff --git a/lib/cmdlib/common.py b/lib/cmdlib/common.py > index 2c44ac7..96b3e04 100644 > --- a/lib/cmdlib/common.py > +++ b/lib/cmdlib/common.py > @@ -1535,7 +1535,7 @@ def DetermineImageSize(lu, image, node_uuid): > return math.ceil(byte_size / 1024. / 1024.) > > > -def EnsureKvmdOnNodes(lu, feedback_fn, nodes=None): > +def EnsureKvmdOnNodes(lu, feedback_fn, nodes=None, silent_stop=False): > """Ensure KVM daemon is running on nodes with KVM instances. > > If user shutdown is enabled in the cluster: > @@ -1558,6 +1558,9 @@ def EnsureKvmdOnNodes(lu, feedback_fn, nodes=None): > @param nodes: if supplied, it overrides the node uuids to start/stop; > this is used mainly for optimization > > + @type silent_stop: bool > + @param silent_stop: if we should issue a warning in case KVM daemon is > already > + stopped
This description can be understood as the value true meaning we should a warning, wheras the opposite is true (as the variable name correctly suggests). Can you please reword it to avoid this confusion? (e.g., "if we should refrain from issuing a warning...") Otherwise looks good. Thanks, Klaus -- Klaus Aehlig Google Germany GmbH, Erika-Mann-Str. 33, 80636 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
