On Tue, May 10, 2016 at 02:28:39PM +0100, 'Federico Morg Pareschi' via
ganeti-devel wrote:
> This commit introduces further test classes and methods for the Create
> family of methods of the BlockDev subclasses and a few additional minor
> cosmetic changes.
>
> Signed-off-by: Federico Morg Pareschi <[email protected]>
Great. A couple of harmless typos, but otherwise LGTM. I'll fix them up and
push.
Cheers,
Brian.
[snip]
> + @testutils.patch_object(bdev.PersistentBlockDevice, "Attach")
> + def testCreate(self, attach_mock):
> + """Test for bdev.PersostentBlockDevice.Create()"""
Nit: PersistentBlockDevice
> + attach_mock.return_value = True
> +
> + expect = bdev.PersistentBlockDevice(self.test_unique_id, [], 0, {}, {})
> + got = bdev.PersistentBlockDevice.Create(self.test_unique_id, [], 1024,
> None,
> + {}, False, {}, test_kwarg="test")
> +
> + self.assertEqual(expect, got)
> +
> + def testCreateFailure(self):
> + """Test for bdev.PersostentBlockDevice.Create() failure"""
Nit: PersistentBlockDevice
[snip]
> testutils.GanetiTestProgram()
> --
> 2.8.0.rc3.226.g39d4020
>
