On Fri, Jun 10, 2016 at 11:28:16AM +0100, Brian Foley wrote: > On Thu, Jun 09, 2016 at 11:13:54PM +0200, Iustin Pop wrote: > > From: Iustin Pop <ius...@google.com> > > > > This function (and getNode, next patch) were two pain points when I tried to > > convert UUIDs to another type, since they're called via a single type > > (currently String) that wants to dispatch to either UUID or name. In many > > cases > > we know exactly what we want to search for, so having only this function is > > overly generic. Not useful yet, but will be later for the string type > > conversion. > > > > Additionally change the name of the existing function getInstanceByName to > > match the new functions better. > > > > Signed-off-by: Iustin Pop <ius...@google.com> > > It took me a little while to convince myself that some of the callers should > use getInstanceByExactName, but I think you're correct.
Note that I don't change that fact; I just renamed getInstanceByName to getInstanceByExactName to make a clear distinction between PartialName and ExactName. But yes, it's a good point if they need to do that. thanks, iustin
