On 12 August 2016 at 15:38, Brian Foley <bpfo...@google.com> wrote:
> On Fri, Aug 12, 2016 at 03:13:53PM +0200, Iustin Pop wrote:
> > On 12 August 2016 at 15:04, 'Brian Foley' via ganeti-devel
> > <[1]ganeti-devel@googlegroups.com> wrote:
> >
> > This makes it a little easier to eyeball the output of make
> > py-tests.
> >
> > Ooh, nice, this is a very old bug, thanks!
> >
> > + logger = logging.getLogger('pyinotify')
> > + logger.propagate = False
> > self.assertRaises(errors.InotifyError, handler.enable)
> > self.assertRaises(errors.InotifyError, handler.enable)
> > handler.disable()
> > self.assertRaises(errors.InotifyError, handler.enable)
> > + logger.propagate = True
> >
> > Do you want to put a try/finally around the asserts that ensure
> > propagate is restored?
> > iustin
>
> Good point. There are paths in pyinotify's add_watch that can throw
> exceptions
> (although I don't think we use them). Submitted with your change.
>
Excellent, LGTM :)
iustin
