On Thu, Oct 13, 2016 at 01:16:39PM +0100, Viktor Bachraty wrote:
>    On Thu, Oct 13, 2016 at 12:48 PM, 'Brian Foley' via ganeti-devel
>    <[1]ganeti-devel@googlegroups.com> wrote:
> 
>      On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via
>      ganeti-devel wrote:
>      This should definitely help cleaning up after migrates. LGTM modulo
>      nits below.
>      > FinalizeMigrationSource and FinalizeMigrationDst should compose an
>      > 'atomic' operation consisting of 2 idempotent steps, that can be
>      always
>      I'm not sure calling this 'atomic' sets the right expecation. For
>      these
>      operations, we want to not continue unless both of them succeed, but
>      we don't
>      guarantee to 'roll back' to the previous state if one or both ops
>      fail.
> 
>    I was thinking calling it 'transactional' but that could also suggest
>    that it either succeeds or rolls back. What I meant to say is that they
>    compose a single operation, consisting of (potentially) parallel steps,
>    that should be always attempted/retried together. Maybe I could use
>    just what I said?

Sounds good! Sorry for the nitpick. As before, LGTM with these changes.

Reply via email to