On Thu, Dec 01, 2016 at 04:09:56AM -0800, Ganeti Development List wrote:
> On Thursday, December 1, 2016 at 11:53:43 AM UTC, Iustin Pop wrote:
> > On Thu, Dec 01, 2016 at 11:38:35AM +0000, Ganeti Development List wrote:
> > > Following issue #1194, this patch allows Ganeti to correctly
> > > parse drbd versions that also include a dash in their k-fix
> > > version component.
> > This means 8.4.8-1 and 126.96.36.199 will be treated the same. Is this the
> > correct behaviour?
> Yes, you are correct. I'm not sure to be honest. I've been looking around
> the drbd and
> also the debian packaging site but I'm not 100% sure what logic follows
> their 'k-fix'
> numbering scheme. In drbd, from what I can see, they always use x.y.z-k
> in one particular (old) version where they do x.y.z.k.
> Honestly, though, as somebody correctly pointed out on the ganeti mailing
> list, does it
> really matter? Shouldn't we mostly only care about major and minor version
> as that
> should be what might break compatibility? All in all I'd say we can treat
> these as
> interchangeable but if somebody disagrees or knows more about this, I'd be
> happy to
> fix it.
No, it doesn't really matter, I was just asking to confirm this is the
plan. I'd suggest updating the commit message to record this explicit
decision (the current one will not be very clear in 2 years whether it
was intended or not).