On Tue, Dec 06, 2016 at 10:12:09PM +0100, Iustin Pop wrote: > On 2016-12-06 17:30:08, Ganeti Development List wrote: > > There are too many cases where we deliberately wrap expressions in > > parens, either to indicate comparisons, or to allow multiline > > expressions without line continuation chars, or to clarify confusing > > precedence. > > > > While here, clean up a few unpythonic cases. > > Nice cleanup, LGTM but one bug below: > > > diff --git a/lib/client/gnt_cluster.py b/lib/client/gnt_cluster.py > > index 3eaf292..b32e62e 100644 > > --- a/lib/client/gnt_cluster.py > > +++ b/lib/client/gnt_cluster.py > > @@ -195,7 +195,7 @@ def InitCluster(opts, args): > > # check the disk template types here, as we cannot rely on the type > > check done > > # by the opcode parameter types > > diskparams_keys = set(diskparams.keys()) > > - if not (diskparams_keys <= constants.DISK_TEMPLATES): > > + if not diskparams_keys > constants.DISK_TEMPLATES: > > You probably wanted to drop the 'not' but missed it.
D'oh! Indeed I did. Thankyou.
