Ramon,
I applied both your patches to my test system here. I like the first
one (of course), but the second one takes away important information.
The min-max are there on the cluster view graphs for a reason: these
bounds are calculated dynamically and need to be shown. Your patch
replaces the min-max values with the units. If you can figure out a
nice way to get both there, that would be better.
-Federico
On Dec 17, 2004, at 8:11 AM, Ramon Bastiaans wrote:
Hi all,
Another patch for the cluster_view, to display the units in the graphs
(now displaying min - max)
This was somehow set in the host_view, but not in the cluster_view.
Kind regards,
Ramon.
--- ../ganglia-old/cluster_view.php Mon Nov 10 19:54:16 2003
+++ ./cluster_view.php Fri Dec 17 16:53:35 2004
@@ -150,6 +150,12 @@
"m=$metricname&";
$graphargs .=
"z=small&c=$cluster_url&h=$host_url&l=$load_color"
."&v=$val[VAL]&x=$max&n=$min&r=$range&st=$cluster[LOCALTIME]";
+ # Adding units to graph 2003 by Jason Smith
<[EMAIL PROTECTED]>.
+ if ($val[UNITS]) {
+ $encodeUnits = rawurlencode($val[UNITS]);
+ $graphargs .= "&vl=$encodeUnits";
+ }
+
}
}
Federico
Rocks Cluster Group, San Diego Supercomputer Center, CA
