martin-sorry about the confusion. i based the new arch-dependent stuff on the 2.5.7 metric.h file. i think i see the problem. there are metric in the solaris ifdef in gmond.c setup_metric_callbacks() that are no longer used.
i don't mind if you want to modify the files to make sure they are in sync. i plan to do a lot of development in gmond.c today so i'm worried we might be fighting for the same file. you can either: 1) send me a patch again a snapshot (i can read the patch and do the mods by hand) or 2) send me a personal email or visit #ganglia on freenode and tell me to take a break while you work your magic.
to be honest, i really don't like that we have stub function in libmetrics at all (and i'd like them gone but haven't had the time). it doesn't make sense for platforms that don't support certain metrics to report the metric as zero. they either should no report a value at all or report NaN (or something like that). the setup_metric_callbacks() function should only register metric that collect real values.
i really tried to knock 2.6.0 into shape to allow a dso model to be derived for registering and communication metric values... once we clean it up... it shouldn't be hard to do at all.
-matt Martin Knoblauch wrote:
Matt, as we are breaking comptibility with 2.6 anyway, could you please adjust [or authorize me to do so] gmond.c to the new set of core metrics. At the moment we have a discrepancy between the arch-dependent #ifdefs of: monitor-core/srclib/libmetrics/libmetrics.h monitor-core/gmond/gmond.c The #ifdes in libmetrics.h are the ones that should be used by 2.6. All metrics.c files have the necessary stubs. Cheers Martin ===== ------------------------------------------------------ Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl _______________________________________________ Ganglia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-developers
--
PGP fingerprint 'A7C2 3C2F 8445 AD3C 135E F40B 242A 5984 ACBC 91D3'
They that can give up essential liberty to obtain a little
temporary safety deserve neither liberty nor safety.
--Benjamin Franklin, Historical Review of Pennsylvania, 1759
signature.asc
Description: OpenPGP digital signature
