On Feb 11, 2008 5:47 PM, Bernard Li <[EMAIL PROTECTED]> wrote: > Hi Jesse: > On 2/8/08, Jesse Becker <[EMAIL PROTECTED]> wrote: > > > Since we seem to be tossing out minor web front end patches tonight, > > here's one that fixes the persistent "0 - 0.00" that shows up on all > > of the per-metric graphs. The patch applies against 3.0.6 and trunk. > > The new behavior is to do the following: > > > > * If an explicit vertical label is passed, use it. > > * If a valid maximum or minimum value has been passed, via the 'x' or > > 'n' URL parameters respectively, use them. > > * If neither are passed, suppress printing a vertical label alltogether. > > > > Note that there should be *something* printed as a label for alignment > > purposes. Otherwise, the sizes of the graphs are off by a few pixels, > > and it looks really bad. > > Not sure if this is the correct way to fix this, see: > > http://ganglia01.slac.stanford.edu:8080/ganglia/glast/?c=glastlnx&m=&r=hour&s=descending&hc=4 > > In older releases, the vertical label actually did something -- with > your patch, it simply removed it (for the load graph).
Nothing is printed if nothing is given to be printed. They are passing explicit, non-zero ranges for the chart. The patch should handle this case. The problem comes from ranges of "0 - 0". This is nonsensical, and worth supressing. If there is a valid range or vertical label passed, then by all means print it. (You'll also note that they are having problems with the "now X.XX" values as well, as well as a strange escaping problem with a parenthesis.) > In the graphs from SLAC, it is labelled 0 - 8.0, however, I'm not sure > whether this information is simply redundant or not. It is redundant, in this case. RRDTool will fill in the ranges be default. The vert-label is more useful for indicating units and similar metadata. If you chart already indicates "0-8", why print it again? One other note about this: the way the limits are found (if not explictly passed) is apparently via find_limits() in functions.php. This function might be broken, since that where $min and $max are set. This function also uses rrdtool to get that information, and means that there will be at least two system() calls to rrdtool for each graph. This probably won't help performance much. -- Jesse Becker GPG Fingerprint -- BD00 7AA4 4483 AFCC 82D0 2720 0083 0931 9A2B 06A2 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ganglia-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ganglia-developers
