>>> On 11/5/2008 at 5:21 PM, in message <[EMAIL PROTECTED]>, "Bernard Li" <[EMAIL PROTECTED]> wrote: > Dear all: > > While trying to upgrade my current 3.1.0 installation of Ganglia with > the 3.1.1.1901 + spoofing RPMs I just built, I noticed that gmond.conf > was created as gmond.conf.rpmnew. > > This doesn't surprise me much, as I know that there were minor > configuration changes between 3.1.0 and 3.1.x branch. > > However, when I ran diff, the result was that the *entire* file was > completely different. > > I double checked this and found out it is the same between 3.1.1 and > 3.1.1.1901 (i.e. the entire 3.1.1 gmond.conf file was different from > 3.1.1.1901 gmond.conf file). > > Turns out, it was because of this recent backport in 3.1.x branch: > > http://ganglia.svn.sourceforge.net/viewvc/ganglia?view=rev&revision=1882 > > Is this really necessary? While in general I am in favour of > whitespace cleanup, in this case I think since it impacts usability, I > think we should punt this until later. >
I have to confess that I was one of the reviewers on this backport and approved it. In light of the conflict that you pointed out, I think that we should probably revert the backport of the whitespace cleanup especially on the .conf files. In general I don't really like patches that are simply style fixes or cleanups. The reason why is because they don't fix any real functional issue and cause enough change in trunk and the stable branch that it causes merging conflicts when trying to backport legitimate functional patches. Coding style and cleanup patches should probably be held off in at least the stable branches (unless part of a functional patch) until just before we decide to release a new version of the code and create a new stable branch for the new version. The Ganglia project source code is in kind of a weird state right now due to a lot of different styles that have been introduced. As a project we should probably decide on our coding style and document this on the wiki (yes, yes I know I am proposing a religious holy war by discussing coding styles, but sometimes you just have to do it). Then just before we move forward with a new branch for 3.2 or 4.0 (or whatever we decide the next major version of Ganglia will be) we all do a massive style and code cleanup. Just my 2 cents. Brad ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
