On Thu, Jan 08, 2009 at 04:13:13PM -0500, Jason A. Smith wrote: > > Recently I started testing the svn version of the web scripts and found > a few bugs.
could you elaborate on the bug this patch is fixing?, the code from trunk and the other 2 active branches seems similar enough to consider this a problem also outside of trunk. > Fixed graph zooming and make sure the default summary graph size > overrides the size selected for the cluster graphs. "graphargs" should contain (in the host view) all host specific parameters that are needed to create the graphs like h (hostname), r (range) and st (start time) but doesn't have z (size) and therefore by moving it to the beginning of the generated URL all it changed is the order used, at least for the report graphs which are the ones that are being patched. for the metrics graph, the order does (sadly) make a difference as the zoom relies on having "z" redefined to "large" through the template, but the patch doesn't apply to that section of the code. could we instead remove the hardcoded values and manage the URLs in a way that makes them not dependent on the order of the parameters so that variables are overriden? Carlo ------------------------------------------------------------------------------ Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
