Brad Nicholes wrote:
>>>> On 7/16/2009 at 9:10 AM, in message <4a5f42d8.9060...@pocock.com.au>,
>>>> Daniel
>>>>
> Pocock <dan...@pocock.com.au> wrote:
>
>> Brad Nicholes wrote:
>>
>>>>>> On 7/16/2009 at 8:07 AM, in message <4a5f3430.20...@pocock.com.au>,
>>>>>> Daniel
>>>>>>
>>>>>>
>>> Pocock <dan...@pocock.com.au> wrote:
>>>
>>>
>>>
>>>> I tried to attach this solution to the bug report, but I get this error:
>>>>
>>>> You did not enter a valid attachment number.
>>>>
>>>>
>>>> Anyhow, this is a solution for bug 232:
>>>>
>>>> http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=232
>>>>
>>>> As a consequence of applying this patch:
>>>> - whenever an RRD is created/updated, the hostname directory name will
>>>> be converted to lowercase
>>>> - any capitalization can be used with the `h' parameter to the web
>>>> interface
>>>> - whenever gmetad receives a hostname in the XML, it will use a
>>>> non-case-sensitive comparison to decide if it already has data for that
>>>> host
>>>> - the XML emitted by gmetad will show the capitalization that was
>>>> received in the XML, not the lowercase version
>>>>
>>>> Anyone applying this patch needs to rename all their hostname
>>>> directories to lowercase.
>>>>
>>>> Regards,
>>>>
>>>> Daniel
>>>>
>>>>
>>> This patch seems reasonable to me. The only part that bothers me is the
>>>
>> fact that an upgrade from a previous version might break existing installs
>> unless they rename all of their rrd directories. That could be a problem
>> for
>> some users that have a large number of monitored boxes.
>>
>>>
>>>
>> Maybe we just make it a part of trunk and the 3.2 release? People
>> (should) look more closely at the readme file when going from 3.1 to 3.2.
>>
>>
>
> I haven't actually tested the patch yet, but I'm OK with just putting it in
> trunk and not backporting it to 3.1. There was a big change between 3.0 and
> 3.1. I would expect that there would be some incompatible changes between
> 3.1 and 3.2 as well. I also think that when 3.2 is released, we should also
> have a helper script like hawson suggested in our /contrib repository. We
> just need to make sure that this in doc'ed somewhere so that when 3.2 is
> released, we can include the doc in the upgrade notes.
>
>
>
One way to make it non-disruptive for 3.1 would be making this new
behavior configurable (as I suggested in the bug) - is it worth the
extra effort of adding a config option for this, or is 3.2 intended to
be released in the new future?
Here's something that can be used as the basis for the helper script
and/or the %post section of the spec file:
killall gmetad
cd $RRDROOT
find . -type d -name '*[A-Z]*' ! -name __SummaryInfo__ -mindepth 2
-maxdepth 2 | while read ;
do
OLD_NAME=`echo "$REPLY" | cut -f3 -d/`
NEW_NAME=`echo "$OLD_NAME" | tr [A-Z] [a-z]`
CLUSTER_NAME=`echo "$REPLY" | cut -f2 -d/`
echo mv "$REPLY" "${CLUSTER_NAME}/${NEW_NAME}"
#mv "$REPLY" "${CLUSTER_NAME}/${NEW_NAME}"
done
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
