On Mon, Aug 17, 2009 at 7:56 PM, Spike Spiegel<fsm...@gmail.com> wrote:

> thanks for your input,

I've given this a go and there's a patch attached to this email that
I'd like to hear comments about. I've never used apr before, but based
on the documentation [1] apr_array_push will allocate new space for
the new element so what I've done is pre-allocating only one element
and then let apr_array_push do the work. I realize this means we're
doing dynamic allocation inside the loop, but given the small number
of items I guess the overhead is negligible.

The patch is against trunk, but looks like it'll work fine on 3.0 branch too.

I'm linking 0.9 but 1.3 is the same for this function

"Behind every great man there's a great backpack" - B.

Attachment: libgmond-trunk-metrics-loss.diff
Description: Binary data

Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
Ganglia-developers mailing list

Reply via email to