On Fri, Sep 18, 2009 at 06:40, <daniel.poc...@barclayscapital.com> wrote: > >> 2) The 'Release' macro is not properly set in the specfile. >> This is because it is defined by the @REL@ autoconf variable, >> which is hard-coded to "1" in configure.in. I propose that >> we change this. >> The simplest thing would be to remove @REL@ from >> ganglia.spec.in, and update the "Release" macro manually. >> The other option is to remember to update REL in configure.in >> each time a change is made to the ganglia.spec.in file. > > I actually introduced that variable, thinking that it would be useful to > have it in a single place (configure.in) and use it for generating both > the spec file and the Solaris pkginfo file. > Obviously, some changes won't impact both platforms (e.g. a change > within the spec file doesn't impact Solaris), but maybe someone will > rebuild the packages for all platforms with no code changes but a > different configure option and they will use @REL@ to show that > something has changed - does that seem reasonable? > > Therefore, I'm not keen to go back to the manual solution, but some > alternative to @r...@...
Fair enough. I didn't realize it was a recent addition, and given the long %changelog, was surprised to see it still at "1". I'll add a note in the specfile about updating it, and bump the version in trunk. -- Jesse Becker ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
