On Wed, Oct 7, 2009 at 06:03, Ramon Bastiaans <ramon.bastia...@sara.nl> wrote: > Hi Jesse, > > Here is the new patch. I rewrote it a bit, since my previous patch could > give some formatting/alignment errors in certain situations.
I took a quick look this morning. > This new patch now handles formatting/alignment properly for everything. > > Let me know if you get around to review it or have any feedback. There are still a few alignment issues with the chart sizes; they are related to the different number of lines of text in each chart (yes, it's a pain, I know...). It's possible that they could be addressed more easily with newer versions of rrdtool (which can specify the size of the image, and scale the chart to fit). A few notes: * There are a few places where I see negative values, that I think should be caught by the RPN calculations. Here's an example: http://bayimg.com/EAEdDaACF * Are the full Now/Max/Avg/Min stats really needed for all of the metrics? I am thinking mostly of metrics that are generally static--such as node count and total RAM installed. * The graph sizes when "$graphreport_stats = false" are misaligned. I think that the code is resizing the graphs, regardless of the number of lines of text used in the legend. And a general question to the list: * When "$graphreport_stats = false", should the behavior be to remove all stats from the graph and have a minimalist view of the data, or to show the more limited "condensed" view as currently in trunk? -- Jesse Becker ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
