Up until now, gmetad hasn't really used APR for any of its base functionality. If we are going to start putting gmetad on top of APR, there are a number of places where gmetad could really be improved. One of the most glaring areas is in the metric_hash code. This code is currently being generated through the gperf tool which produces C code that is very specific to a certain set of tags and how they should be hashed. Furthermore, if there are changes to any of the metric tags, this hashing code has to be manually generated before any of the autotools can be run. It would really be nice to remove gmetad's dependance on the gperf tool and instead put all of the hashing functionality on top of the apr_hash*** table functions. These functions are much more flexible and would remove a significant amount of complex code.
In addition to that, there are many other areas such as threading and memory which could really benefit from APR. Not to mention portablility. Just a thought in case anybody is looking for someplace where they could really contribute to Ganglia. Brad >>> On 11/20/2009 at 8:05 AM, in message <4b06b01d.3050...@pocock.com.au>, >>> Daniel Pocock <dan...@pocock.com.au> wrote: > > As discussed previously on the list, I've adapted gmetad to use apr's > sleep functionality. For anyone using trunk, please run autoreconf && > ./configure to get the newest gmetad/Makefile > > Changing the sleep code to randomize intervals using a percentage rather > than absolute value should be helpful for shorter polling intervals - I > would be interested in any feedback from people using Ganglia for > polling intervals smaller than 15 seconds. > > The change is in trunk but may be backported for 3.1.5 > > ------------------------------------------------------------------------ > r2106 | d_pocock | 2009-11-20 14:58:09 +0000 (Fri, 20 Nov 2009) | 1 line > > Rewrite gmetad sleep code in various places to use apr, remove magic > numbers, sleep as a percentage of the step rather than an absolute > random adjustment > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > Ganglia-developers mailing list > Ganglia-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ganglia-developers ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
