Hi Carlo:
On Sat, Jun 26, 2010 at 4:56 AM, Carlo Marcelo Arenas Belon
<care...@sajinet.com.pe> wrote:
> this would trigger gmond to segfault unless it was linked against
> libconfuse 2.7 or it also has a default gmond.conf file created.
Actually, gmond would segfault with or without this patch, this is
because the default configuration has the line:
include ("$sysconfdir/conf.d/*.conf")
which causes libconfuse to segfault.
I was thinking that it does not make sense to include this in the
"default" configuration file, which is used when no configuration file
is found. The reason is if no configuration file is found, you would
not expect to have other configuration files lying around to be
included.
One way to fix this, is to only include this line when we are trying
to output this to standard out via `gmond -t`. This way gmond can
still function without a configuration file, and the default
configuration outputting still works as expected and users won't need
libconfuse 2.7 to get gmond working the way it's supposed to be --
what do you think?
> installing the example modules by default might not be a good idea, as
> they are just generating bogus metrics anyway.
Agreed, but they are "installed", but not turned on (note the
pyconf.off extension).
> also, as you pointed out since these modules are linux specific and only
> needed on some setups they were intentionally not included in the default
> install as they are generally pulled as needed by the packager/sysadmins
> that are interested on them anyway.
How about a new target like `make install_gmond_modules`?
The reason why I decided to do this is because users who build from
source may not know about these modules, or know where they are
supposed to go. So I thought it would be nice to make it easier for
them to discover this.
Thanks,
Bernard
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
